search

projekt0n / github-nvim-theme

GitHub's Neovim themes
MIT License
2.07k stars 106 forks source link

border is not required when using dark_sidebar #228

Closed yamatsum closed 1 year ago

yamatsum commented 1 year ago

There is no line on sidebar border in vscode. (not strictly noticeable) CleanShot 2023-01-22 at 00 19 07@2x

border is not required when using dark_sidebar. CleanShot 2023-01-22 at 00 20 47@2x

ful1e5 commented 1 year ago

In Vim, all split windows are considered to be actual buffers. To change the color of the line between the nvim-tree and the buffer, it is necessary to assign a color to the VertSplit highlight. However, implementing this change will apply to all vertical split window division lines, which can negatively impact readability. Vim users typically prefer to distinguish between their buffers while splitting. On the other hand, VSCode has a separate group for assigning colors to its Explorer (file browsing sidebar).

If this request is feasible through the use of nvim autocmds, I would like to propose it as a feature request during or after a refactoring process. If any alternative solutions or workarounds are available, they would be greatly appreciated.

If you don't mind, could you please share the font used in the screenshot?

yamatsum commented 1 year ago

How about using NvimTreeVertSplit?

If you don't mind, could you please share the font used in the screenshot?

ful1e5 commented 1 year ago

There is no highlight feature that compares to the NvimtreeVertSplit offered by the nvim-tree plugin. I attempted to override the highlight, but was not successful. If we are able to successfully override this highlight, we may consider other sidebar-related plugins such as litee.nvim and neo-tree, to maintain a consistent aesthetic. I believe it may be possible to achieve this through the use of autocmds, similar to the method used for darkening sidebars.

Thank you for sharing the font.

yamatsum commented 1 year ago

@ful1e5 I'm sorry, the name of the highlight seems to have changed. https://github.com/nvim-tree/nvim-tree.lua/pull/1219 It worked well with NvimTreeWinSeparator

ful1e5 commented 1 year ago

The NvimTreeWinSeparator highlight appears to be functioning properly, however, when the side option is changed to 'right', it no longer functions correctly. It appears to be an issue with the plugin.

https://user-images.githubusercontent.com/24286590/214258511-5c11a190-f451-4608-815b-8ada36ce7768.mp4

ful1e5 commented 1 year ago

Try a new revision on main after 4d5a4ce881d5d412b7f10f6b2fc7b3531a5138cc.