projekt0n / github-nvim-theme

GitHub's Neovim themes
MIT License
2.07k stars 106 forks source link

refactor: Replace `CmpItemKind*Default` with `CmpItemKind%KIND_NAME%` #234

Closed fitrh closed 1 year ago

fitrh commented 1 year ago

Using CmpItemKind*Default causes an issue where nvim-cmp overrides the colorscheme if loaded later, e.g. lazy-loading on InsertEnter event.

According to nvim-cmp/plugin/cmp.lua#L28, the CmpItemKind*Default is not to be overridden because they sets [default] to false, also, in :h cmp-highlight they never mentions CmpItemKind*Default.

The following differences use the dark_default variant and load nvim-cmp on InsertEnter and CmdineEnter

Before

20230216_211720

After

20230216_211656