search

projekt0n / github-nvim-theme

Github's Neovim themes
MIT License
2.02k stars 105 forks source link

Coloring is off? #237

Closed Lambdaphile closed 1 year ago

Lambdaphile commented 1 year ago

Hi, sorry for the vague title, wasn't sure how to name this issue.

I use the same theme in VSCode, and the color pallet is much richer there. That's what I mean: Screen Shot 2023-03-11 at 15 50 15 (2)

VS the github-nvim-theme in Neovim v.0.8.3+ Screen Shot 2023-03-11 at 15 50 53 (2)

At first, I thought that this was a Neovim issues, but then I checked other themes like tokyonight and they're ok: Screen Shot 2023-03-11 at 15 58 13 (2)

Is this a known thing, done on purpose, will it get fixed in the upcoming rewrite?

ful1e5 commented 1 year ago

Is this a known thing, done on purpose, will it get fixed in the upcoming rewrite?

Yes.

sethawright commented 1 year ago

For now, make sure you are using tag 0.0.7 in your plugin manager.

 -- lazy.nvim
  {
    "projekt0n/github-nvim-theme",
    tag = "v0.0.7",
    config = function()
      require("github-theme").setup({})
      vim.cmd("colorscheme github_dark")
    end,
  },
tmillr commented 1 year ago

I'm having the same issue. In a js file, parenthesis are blue, but they're supposed to be the foreground color (or similar in color to the global foreground color). Im using the dimmed variant.

Edit: same deal with variables (@variable or @variable.javascript highlight group)

ful1e5 commented 1 year ago

Try a new revision on main after 4d5a4ce881d5d412b7f10f6b2fc7b3531a5138cc. Refactoring is almost done; only docs and new features are left. Report any theme highlight issues here or on #226. I want to merge them upstream before release.

tmillr commented 1 year ago

@Lambdaphile Try updating the plugin. Alot of highlighting changes just landed on the main branch.

ful1e5 commented 1 year ago

Closing due to inactivity. Can reopen later.