Adding netrw to sidebars has no effect

[ghost]

Below config does not change anything for netrw:

require('github-theme').setup({
    theme_style = "dark_default",
    sidebars = { "netrw" },
})

If I override bg_sidebar then every window's background changes:

require('github-theme').setup({
    theme_style = "dark_default",
    sidebars = { "netrw" },
    colors = { bg_sidebar = "#000000" },
})

And this one also has no effect at all:

require('github-theme').setup({
    theme_style = "dark_default",
    colors = { bg_sidebar = "#000000" },
})

[ful1e5]

@dr4gut Which branch are you using, main or v0.0.x?

[ghost]

@dr4gut Which branch are you using, main or v0.0.x?

@ful1e5 Tried both master and v0.0.7. Results are the same

[ful1e5]

The issue has been resolved in 4d5a4ce881d5d412b7f10f6b2fc7b3531a5138cc. Please use the following updated configuration:

require('github-theme').setup({
  options = {
    darken = {
      sidebars = {
        enable = true,
        list = { 'netrw' },
      },
    },
  },
})

vim.cmd.colorscheme('github_dark')

[ghost]

@ful1e5 so I'm trying this out but I did not get what I expected. Do I maybe understand this feature wrong? I'd expect the netrw window on the left to have a darker background.

I am on master:

[ful1e5]

@dr4gut I can't reproduce it. I'm accessing netrw with the :Explore command, and it has a dark background. Could you please share your github-theme and netrw configurations or the steps to reproduce it?

[ghost]

@ful1e5 I clean installed linux and neovim (for other reasons :)) but this problem went away too. Thanks.