Rust highlighting colors with treesitter appear to be wrong

projekt0n / github-nvim-theme

Github's Neovim themes

MIT License

2.02k stars 105 forks source link

Rust highlighting colors with treesitter appear to be wrong #256

Closed koritar-aqg closed 1 year ago

koritar-aqg commented 1 year ago

Hi, I installed this theme today and the colors on my Rust code seems pretty off of what it should look like.

This is how I installed and configured it using lazy.nvim:

Here's a screenshot of the theme on my neovim config:

And here's how it should look like based on github and vscode theme:

AlexXi19 commented 1 year ago

+1 on this. Colors are still a bit off 😞 . This is with github dark high contrast. Though the coloring seems a bit better compared to before the refactor. Screenshot 2023-05-22 at 12 40 57 PM Screenshot 2023-05-22 at 12 41 03 PM

tmillr commented 1 year ago

Try updating the plugin. A bunch of changes were just merged in #259. It might not be perfect yet, but it should be a substantial improvement:

Dimmed

Dark

Light

Dark High Contrast

koritar-aqg commented 1 year ago

Just updated the plugin and tested it out, looks way better than before, there are some wrong colors here and there and as you said it's not perfect yet, but overall it's really good! Really appreciate your work!

tmillr commented 1 year ago

Just updated the plugin and tested it out, looks way better than before, there are some wrong colors here and there and as you said it's not perfect yet, but overall it's really good! Really appreciate your work!

Awesome thank you! If there's anything specific left you'd like to report or want checked out, feel free to leave a comment on #252.