Closed tmillr closed 1 year ago
Should be ready to merge soon! 👍 (next 2-3 days)
@ful1e5 I think this one is pretty much ready (although it depends on #273 so that should be merged first). I think that further refinements such as tweaking highlights even further, refactoring, or addressing less commonly used languages, etc., can come later if needed. I didn't touch the CHANGELOG.
This pr ended up touching many files so it may be easier to view the diffs one commit at a time. Thanks
Please make the necessary changes to README.md#Configuration.
Oops. Sorry for missing that.
These changes might require multiple PR's in order to: quickly deliver highlight fixes, achieve cleaner/smaller pr's, etc.. Feedback and suggestions are welcomed!
It may be possible to refactor all of the
palette/*
files into a single file? Although I'm not sure if this is something that is wanted or desired, plus after all is said and done, there may remain some custom differences/tweaks among the different colorschemes when it comes to the non-syntax colors/highlights within these files? So for now, I am thinking that it may be best to simply put such questions (of refactoring, etc.) off until later, and in the meantime just develop a new file/module containing all of the common mappings (from hl-group to primer primitives color) that will then berequired()
within each of thepalette/*
files.Todo's, Notes, Ideas, Considerations, Etc.
rgb()
andrgba()
color strings (not applicable to pl syntax colors)TODO
commentsSee #252