projekt0n / github-nvim-theme

GitHub's Neovim themes
MIT License
2.11k stars 106 forks source link

ci(update-colors): fix update-color-primitives.yml #272

Closed tmillr closed 1 year ago

tmillr commented 1 year ago

For whatever reason, the stylua action was not properly stripping the single quotes that are passed within the args: (even though this action uses NodeJS exec() which says that it uses /bin/sh on Unix to execute the command-line...go figure). Anyway, the single quotes were removed.

Also, permissions required for the automated pull request to succeed were added.


I went through the hassle of making sure that it actually works this time because I've had the worst luck with this! lol. You can view the generated pr here.

The only other requirement for this to work properly is that the repo or organization needs to be configured to allow pr's from GitHub actions, otherwise the automated pr will not go through. While testing, I found out that this setting is not enabled by default. It can be enabled under either repo or organization settings under the Actions tab (if not done so already).

ful1e5 commented 1 year ago

@tmillr I checked the settings, and it's enabled.

20230601_17h03m32s_grim

Thank you for contributing, mate.

ful1e5 commented 1 year ago

It worked. Check #273.