github light high contrast: Floating window has same color as background - Githubissues

projekt0n / github-nvim-theme

GitHub's Neovim themes

MIT License

2.11k stars 106 forks source link

github light high contrast: Floating window has same color as background #324

Open bluss opened 4 months ago

bluss commented 4 months ago

Using nvim v0.9.5, github-nvim-theme d832925 with lazy.nvim package manager.

It looks like Normal and NormalFloat have the same background color, and this means that things like hover floaters (using NormalFloat) wash out against the background. github light default does not have this problem.

Both light/dark high contrast themes have this same issue.

tmillr commented 2 months ago

Thanks for reporting this. You are right, and this only affects github_light_high_contrast and github_dark_high_contrast.

Screenshot 2024-07-11 at 1 19 10 PM

https://github.com/projekt0n/github-nvim-theme/blob/6829ce38c1337c5858f7d1abd2c84a492c2c46b3/lua/github-theme/palette/primitives/light_high_contrast.lua#L410-L415

https://github.com/projekt0n/github-nvim-theme/blob/6829ce38c1337c5858f7d1abd2c84a492c2c46b3/lua/github-theme/palette/primitives/dark_high_contrast.lua#L410-L415

canvas.default is used for spec.bg1 (global bg), and canvas.inset is used for spec.bg0 (darkened bg)

We might need manual/custom overrides for these two themes (for spec.bg0). In the meantime, you can configure spec.bg0 via setup() locally.