search

projekt0n / github-nvim-theme

GitHub's Neovim themes
MIT License
2.11k stars 106 forks source link

Transparency for floats (mini.files, mini.clue, and mini.pick incl. trouble.nvim, etc.) #337

Closed 231tr0n closed 2 months ago

231tr0n commented 3 months ago

When transparency is turned on, mini.files, mini.clue and mini.pick still have background including trouble.nvim. image image image image

tmillr commented 2 months ago

Gotta figure out how options.transparent = true should combine with options.darken.floats = true. It should probably just override it (as is currently done for sidebars in this case) and just use transparency instead (plus, it's not like we can trivially figure out, implicitly, what the terminal bg is in order to make the float bg darker than it). Ideally, the floats config would be changed to an enum of string (e.g. 'transparent' | 'darken') instead of a boolean, but then it'd probably have to be moved out of options.darken. Either that or a notice in the docs that options.transparent overrules options.darken.* when both are enabled.

Also have to make sure that neovim handles this properly/intelligently and doesn't act similar to vim.wo.winblend = 100 when a float has its bg unset (EDIT: can confirm that it doesn't do this). Because then text from vim windows underneath the float would leak through and be visible.