Closed wimstefan closed 3 years ago
I patched 6a95cca to the upstream. Now you are able to set transparent background with NONE
value.
vim.o.background = "dark"
local transparent = true
if vim.o.background == "dark" then
local themeStyle = "dimmed"
local colors = require("github-theme.colors").setup({themeStyle = themeStyle})
require("github-theme").setup({
colors = {bg_folded = transparent and "NONE" or colors.bg_sidebar},
sidebars = {"netrw", "packer", "qf", "terminal"},
themeStyle = themeStyle,
transparent = transparent
})
else
local themeStyle = "light"
local colors = require("github-theme.colors").setup({themeStyle = themeStyle})
require("github-theme").setup({
colors = {bg_folded = transparent and "NONE" or colors.bg_sidebar},
sidebars = {"netrw", "packer", "qf", "terminal"},
themeStyle = themeStyle,
transparent = transparent
})
end
Also, You don't have to override the fg_folded
value to colors.fg
because it's already assigned inside colors.lua.
Looking good. Very good :D
I guess I simply was thinking the wrong way when I supposed that bg_sidebar
is getting transparent as well just when I've set transparent = true
;)
Thank you so much for your support! 🙏
I'm assigning different colors to folds as you suggested in issue #26 and it works so well :)
There is one thing though which I don't understand: Using
should give me a transparent fold{,column} background if
transparent
is set totrue
if I understand the configuration in colors.lua correctly? It is not the case in my configuration ... Here is the content of nvim_theme.luaI'm sure I'm doing something wrong but I couldn't find the solution yet ...