search

projekt0n / github-theme-contrib

GitHub's themes ports and extras
MIT License
134 stars 9 forks source link

Can't import any iTerm2 themes #10

Closed Kristijan closed 1 year ago

Kristijan commented 1 year ago

I'm running iTerm2 Build 3.4.20, and I've cloned the repository, but can't seem to import any of the themes.

Each one I attempt comes back with

Import Failed. The selected file could not be read or did not contain a valid color scheme.

Permissions on the files appear fine, as I can read all of them.

Kristijan commented 1 year ago

Digging a little into it, each file appears to have a closing </dist> tag, without an opening one. I managed to fix the import issue in one file by removing it, and also adding <dict> ... </dict> parent tags immediately after the opening <plist version="1.0">.

I'm happy to make a pull request, but I know nothing when it comes to theme files, so unsure if the above is simply unique to me, or an actual issue with the files and what I've done is the correct fix.

brainplot commented 1 year ago

I have the same issue even with the dist tag present. I have the repo checked out at commit 4eb8179 and get the same error message when trying to import the themes in iTerm2.