search

projen / projen

Rapidly build modern applications with advanced configuration management
https://projen.io
Apache License 2.0
2.53k stars 362 forks source link

fix(gitlab): render tag !reference without quotes #3616

Open JohannesKonings opened 3 weeks ago

JohannesKonings commented 3 weeks ago

Fixes https://github.com/projen/projen/issues/3590

Here is an approach which works. Unfortenately I didn't managed to get the custom tags to work like described here: https://eemeli.org/yaml/#writing-custom-tags I also had some struggle with JSII 😄 Maybe with some help we find a solution that works and looks not so hacky.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.36%. Comparing base (ad20d2c) to head (3129c15). Report is 83 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3616 +/- ## ========================================== + Coverage 96.34% 96.36% +0.01% ========================================== Files 192 193 +1 Lines 37696 38003 +307 Branches 3524 3552 +28 ========================================== + Hits 36320 36621 +301 - Misses 1376 1382 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mrgrain commented 3 weeks ago

Appreciate the effort, but not keen on the string replacements. Certainly not as a generic option on YAML file.

I also had some struggle with JSII 😄

I suspect we will need to mark custom tags as @internal and basically only allow them for built-in features and TS. I try to come up with a proposal you can take over the line.