projen / projen

Rapidly build modern applications with advanced configuration management
https://projen.io
Apache License 2.0
2.53k stars 362 forks source link

fix(next): use module commonjs for dev tsconfig #3620

Closed JohannesKonings closed 3 weeks ago

JohannesKonings commented 3 weeks ago

Fixes https://github.com/projen/projen/issues/3442

As far as I understand tsconfig.dev.json will only used for projen synthing, so that the module could switch to commonjs without effecting the standard tsconfig for nextjs. Another approach could be to switch to npx tsx .projenrc.ts as default task for projen (https://www.typescriptlang.org/docs/handbook/modules/guides/choosing-compiler-options.html#im-using-tsx)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.36%. Comparing base (ad20d2c) to head (295529b). Report is 81 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3620 +/- ## ========================================== + Coverage 96.34% 96.36% +0.01% ========================================== Files 192 193 +1 Lines 37696 37978 +282 Branches 3524 2663 -861 ========================================== + Hits 36320 36596 +276 - Misses 1376 1382 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.