search

projen / projen

Rapidly build modern applications with advanced configuration management
https://projen.io
Apache License 2.0
2.53k stars 362 forks source link

feat: support configuring eslint command flags #3655

Open timothymathison opened 1 week ago

timothymathison commented 1 week ago

Adds an option to disable --fix flag and an option to provide additional flags for the eslint command run by the eslint task.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.37%. Comparing base (ad20d2c) to head (a080ed6). Report is 104 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3655 +/- ## ========================================== + Coverage 96.34% 96.37% +0.02% ========================================== Files 192 193 +1 Lines 37696 38060 +364 Branches 3524 2666 -858 ========================================== + Hits 36320 36679 +359 - Misses 1376 1381 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

timothymathison commented 1 week ago

@mrgrain any idea why there's test failures for windows - unrelated to my changes?

mrgrain commented 1 week ago

Ignore the windows tests for now. They are still in development. Sorry for the confusion.

I'm quite busy this week but should be able to get to a review by end of it.