search

projg2 / smart-live-rebuild

Update live packages whose remotes have changed
BSD 2-Clause "Simplified" License
47 stars 7 forks source link

Remove possible `getbinpkg` feature from the environment #9

Closed nertpinx closed 6 years ago

nertpinx commented 6 years ago

My previous commit (e473be02e32d) tried fixing the issue of rebuilding binary packages (they were fetched from the $PORTAGE_BINHOST), but forgot to also remove the getbinpkg feature from the FEATURES (either set explicitly or in make.conf). This patch removes the feature if it is specified in the environment and explicitly adds -getbinpkg to the feature list.

nertpinx commented 6 years ago

It could be written in a way more straightforward way (directly appending getbinpkg into FEATURES of the current environment), but I like to be more cautious. Feel free to (request a) rewrite.

mgorny commented 6 years ago

Wait a minute… why would FEATURES override explicit command-line argument? That looks like a bug in Portage.

nertpinx commented 6 years ago

Good point, I haven't though of it that way. That looks like a bug in my head =) I'll see what it looks like in portage, but I've never seen that codebase before.

mgorny commented 6 years ago

Please start by reporting at bugs.gentoo.org, Portage Development product.

nertpinx commented 6 years ago

Completely forgot this, consider it a non-issue anymore.

Filed here: https://bugs.gentoo.org/670482