search

proksee-project / proksee-cmd

Repo for Proksee Cmd Line Tools
Apache License 2.0
21 stars 2 forks source link

Adding config.json to MANIFEST.in #75

Closed emarinier closed 2 years ago

emarinier commented 2 years ago

Adding the config file to the manifest file and moving inside the source directory, because when Conda / Galaxy pip installs it, it cannot find the config file.

Alternate solutions that leave config.json at the project root level have a potential problem in that they may be clobbered by other packages installed with pip that do the same. Since you end up with something like:

pip/
  - config.json
  - proksee/
  - proksee-1.0.0a3.dist-info/
emarinier commented 2 years ago

Cherry picking the quast=5.0.2 fix.

emarinier commented 2 years ago

This is probably better solved by adding the config file to the manifest: https://github.com/proksee-project/proksee-cmd/blob/develop/MANIFEST.in

emarinier commented 2 years ago

@ericenns Should be ready for review! :)