proksee-project / proksee-cmd

Repo for Proksee Cmd Line Tools
Apache License 2.0
21 stars 2 forks source link

Various small fixes for v1.0.0a5 #79

Closed emarinier closed 1 year ago

emarinier commented 1 year ago
emarinier commented 1 year ago

@ericenns The solution for using shorter relative paths instead of longer absolute paths involves finding the common path of all input files and working from the directory of the common path. There's a bit of extra logic to handle when there's only 1 input file or multiple input files in completely different directories.

emarinier commented 1 year ago

Thanks Aaron. Good catch. It turns out I needed to take the absolute path of any file I try to take the directory name from, because a relative path without a directory (ex: "contigs.fasta") would return an empty string for the dirname and then subprocess would try to run the process from an empty string directory.

emarinier commented 1 year ago

I made one other comment about parallel mash screen (just writing this here again so it's part of a review).

Added in d1071ce