search

prolane / samltoawsstskeys

Google Chrome Extension which converts a SAML 2.0 assertion to AWS STS Keys.
MIT License
139 stars 91 forks source link

Custom Session Duration and default duration is 4 hours #55

Closed Prounckk closed 1 year ago

Prounckk commented 1 year ago
Screen Shot 2022-11-01 at 3 29 39 PM
Prounckk commented 1 year ago

Hey, @prolane I wonder if you could review this PR. This was very beneficial for my team and i see, people, asking for this in the Issues.

prolane commented 1 year ago

Hi @Prounckk, sorry for the late reply. Thanks for your this PR.

Google is soon pushing developers to Extension manifest V3, which is quite an impact for many devs. This includes this very extension. With the limited time I have available, I've actually been working in the background on refactoring the code to fit the V3 manifest requirements. I've just moved the refactored code to master, which unfortunately now introduces some merge conflicts for your PR.

But no need to worry. I like your proposal. I'll try to free up some more time very soon to fix the conflicts, refactor just a little bit to let it fit to my likings and then I'll release another version.

Cheers!