search

prolane / samltoawsstskeys

Google Chrome Extension which converts a SAML 2.0 assertion to AWS STS Keys.
MIT License
139 stars 91 forks source link

Accept role list as string value #60

Closed bskiefer closed 1 year ago

bskiefer commented 1 year ago

Allows processing the role with the following response:

<Attribute Name="https://aws.amazon.com/SAML/Attributes/Role">
    <AttributeValue>arn:aws:iam::ID:role/RoleName,arn:aws:iam::ID:saml-provider/WAAD</AttributeValue>
</Attribute>
prolane commented 1 year ago

Hi @bskiefer , I've just published v3.1 as a fix for #58. This includes a few small changes which are related to your PR.

https://github.com/prolane/samltoawsstskeys/blob/b198466f66ef5db8275db0c24c7f5395368491fb/background/script.js#L98 https://github.com/prolane/samltoawsstskeys/blob/b198466f66ef5db8275db0c24c7f5395368491fb/background/script.js#L178

In my own IDP setup, I actually have a test scenario containing the same format of SAML Assertion AttributeValue as you posted here. On my end this is processed correctly. Therefore, at this moment I don't see the need for this PR.

Please wait for Google to release v3.1, hopefully somewhere tomorrow. Give it a try and let me know if this fixed the issue for you. If not, please reopen the PR and provide me with the debug logs from the extension.

Cheers mate.

bskiefer commented 1 year ago

3.2 seems to be worked as expected. Thanks!