Added ability to change strategy of rejection a message

prolic / HumusAmqp

PHP 7.4 AMQP library

https://humusamqp.readthedocs.io/

MIT License

76 stars 17 forks source link

Added ability to change strategy of rejection a message #52

Closed yethee closed 7 years ago

yethee commented 7 years ago

Ref #49

BC break. Now, flushDeferred returns FlushDeferredResult::MSG_REJECT_REQUEUE() by default, when thrown an exception during flush deferred messages. If this change is critical, we can exctract a piece of logic out of handleException.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 92.629% when pulling be5ac1b55d2dca7479580f3312ed52ddd6e461a3 on yethee:issue-49 into eae4cef3b50728e5754dcf79bece3605b551311a on prolic:master.

prolic commented 7 years ago

I think is this only a very small BC and can be done with a minor release and some migration notes.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 92.686% when pulling 5e19fef00edbbad3b7bb0358c74945f30e4b91df on yethee:issue-49 into eae4cef3b50728e5754dcf79bece3605b551311a on prolic:master.

prolic commented 7 years ago

Thanks a lot! Really appreciate your contribution.