search

prolic / HumusAmqp

PHP 7.4 AMQP library
https://humusamqp.readthedocs.io/
MIT License
76 stars 17 forks source link

removes unused argument from rpc server factory #56

Closed oqq closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.004%) to 92.681% when pulling 183dff639b8f0d8b6720f8c71f1ee0c1daed3303 on oqq:minor/factory_improvements into e1f298debdfdf609c742258ccfee37c149dde57c on prolic:master.

prolic commented 6 years ago

Uuh, good catch, this is indeed not implemented, I planed it, but obviously forgot the implementation.

The idea is, that if the JsonRpcServer throws any Exception, and this flag is turned on, then the server would return the exception trace to the client. This is especially useful for debugging in development mode. Do you want to take over the implementation? Otherwise I'll create a ticket and take care of it myself, asap.