search

prolic / HumusAmqp

PHP 7.4 AMQP library
https://humusamqp.readthedocs.io/
MIT License
76 stars 17 forks source link

Implement JsonRpcError factory #70

Closed eyudkin closed 4 years ago

eyudkin commented 6 years ago

For now usages of JsonRpcError are hardcoded (i.e. in JsonRpcClient) and I need to fork them to use other error class (even if I'll use Humus\Amqp\JsonRpc\Error interface). Im suggesting to implement JsonRpcErrorFactory class which will be used to create error objects. In this case, I'll be able to handle error creation without deep forks and etc.

prolic commented 6 years ago

Can you provide a PR without doing a BC?