Use pcntl_async_signals for php >=7.1

prolic / HumusAmqp

PHP 7.4 AMQP library

https://humusamqp.readthedocs.io/

MIT License

76 stars 17 forks source link

Use pcntl_async_signals for php >=7.1 #79

Closed genhoi closed 4 years ago

genhoi commented 4 years ago

I suggest raising the minimum version of php to 7.1 and use pcntl_async_signals for best perfomance

prolic commented 4 years ago

Yes agree, I leave this ticket open for a short while, because this requires a minor version bump. I want to have all PR's merged before I put this in and tag a new release.

Thanks for your contribution.

prolic commented 4 years ago

Can you rebase this? Tests are failing.

genhoi commented 4 years ago

Can you rebase this? Tests are failing.

I’ll do it tonight

genhoi commented 4 years ago

Done