prolic / HumusAmqp

PHP 7.4 AMQP library
https://humusamqp.readthedocs.io/
MIT License
76 stars 17 forks source link

php-amqplib 2.9 support #84

Closed prolic closed 4 years ago

prolic commented 4 years ago

There is a failing test case right now, you can execute it isolated like this:

./vendor/bin/phpunit --stop-on-failure --group=failing_test tests/PhpAmqpLib/CallbackConsumerTest.php

I hope this helps to debug the issue and resolve it. Unfortunately I'm out of time right now. Hopefully I can come back and finish this soon.

If anyone wants to take over from here, feel free! @genhoi @func0der

bweston92 commented 4 years ago

Seems to be a few issues going on for example $queue->get is also failing, I can see the messages queued in the queue on RabbitMQ are fetched but not acked. I have checked the change log and not much has changed since v2.9

1) HumusTest\Amqp\PhpAmqpLib\CallbackConsumerTest::it_handles_flush_deferred_after_timeout
Error: Call to a member function getBody() on boolean

/home/bweston/workspace/src/github.com/prolic/HumusAmqp/tests/AbstractCallbackConsumerTest.php:453
bweston92 commented 4 years ago

Glad to see this got solved. Good work both of you :)