prolic / HumusAmqp

PHP 7.4 AMQP library
https://humusamqp.readthedocs.io/
MIT License
76 stars 17 forks source link

symfony/console: ^5.0 compatibility #86

Closed rppgorecki closed 4 years ago

rppgorecki commented 4 years ago

Console actions ready for symfony/console 5.*

Execute command should return int, if not error is thrown:

PHP Fatal error: Uncaught TypeError: Return value of "Humus\Amqp\Console\Command\ShowCommand::execute()" must be of the type int, NULL returned. in /var/www/html/vendor/symfony/console/Command/Command.php:258

prolic commented 4 years ago

@rppgorecki see https://github.com/prolic/HumusAmqp/blob/master/composer.json#L21

Console v5 isn't even allowed as of now. If nothing else breaks, we can try to enable support for v4 and v5 as well, but that should at least be tested first.

rppgorecki commented 4 years ago

@prolic I've updated composer.json - all checks have passed (It's really simple change, but needed if you use newer symfony/console in your project)

prolic commented 4 years ago

Thanks a lot