Require PHP 7.4 - Githubissues

prolic / HumusAmqp

PHP 7.4 AMQP library

https://humusamqp.readthedocs.io/

MIT License

76 stars 17 forks source link

Require PHP 7.4 #94

Closed prolic closed 4 years ago

prolic commented 4 years ago

BC BREAK

Instead of returning FALSE from the queue, when no message was found, it returns NULL instead.
ConnectionOptions class has getters renamed (no get-prefix)

prolic commented 4 years ago

@func0der @rppgorecki @genhoi wanna review and let me know if you find any problems?

rppgorecki commented 4 years ago

I would love to be able to stay with php 7.3 (migration to 7.4 might be time consuming) and yet have all new features included in present master branch. Can we do 2 releases? First without this PR (1.4.3) and second with php 7.4 (1.4.4)?

prolic commented 4 years ago

@rppgorecki This will be a new major release (2.0), but I can do a release candidate (2.0 RC1) first without this patch. I don't want to maintain multiple versions at the same time, due to time constraints.