PHP 7 compatibility and tests - Githubissues

prolic / HumusAmqpModule

AMQP module for Zend Framework 2 to integrate RabbitMQ

https://humusamqp.readthedocs.io

MIT License

31 stars 13 forks source link

PHP 7 compatibility and tests #36

Closed thomasvargiu closed 8 years ago

thomasvargiu commented 8 years ago

Added more tests
Tests with docker
Dependencies fix (Added zend-log and changed version syntax)

Tests with docker will allow us to make some integration tests, starting a container with RabbitMQ during travis-ci build.

prolic commented 8 years ago

wow, great stuff! thank you!

only two things: 1) perhaps it's better to update the requirement to ext-amqp 1.7 instead of 1.4. also because 1.4 has a lot of crashes and 1.7 is much more stable. 2) i would not allow build failures for php 7, is there a specific reason for this?

thomasvargiu commented 8 years ago

Yep, we can update the requirement to ext-amqp 1.7. Allowed failures for php 7 are only for ext-amqp 1.4.0 because only 1.7.0 is compatibile with PHP 7.

I also suggest to upgrade ZF dependencies to 2.7, in order to makes changes to make the library compatibile with ZF 3. What do you think?

prolic commented 8 years ago

Sounds good, do you want to update the pr? Am 09.05.2016 21:14 schrieb "Thomas Mauro Vargiu" <notifications@github.com

:

Yep, we can update the requirement to ext-amqp 1.7. Allowed failures for php 7 are only for ext-amqp 1.4.0 because only 1.7.0 is compatibile with PHP 7.

I also suggest to upgrade ZF dependencies to 2.7, in order to makes changes to make the library compatibile with ZF 3. What do you think?

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/prolic/HumusAmqpModule/pull/36#issuecomment-217860664

prolic commented 8 years ago

Btw: i am working on a new lib HumusAmqp (framework independent and php 7 only with different drivers). I am looking for some feedback, am currently trying to resolve some issues. Am 09.05.2016 21:14 schrieb "Thomas Mauro Vargiu" <notifications@github.com

:

Yep, we can update the requirement to ext-amqp 1.7. Allowed failures for php 7 are only for ext-amqp 1.4.0 because only 1.7.0 is compatibile with PHP 7.

I also suggest to upgrade ZF dependencies to 2.7, in order to makes changes to make the library compatibile with ZF 3. What do you think?

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/prolic/HumusAmqpModule/pull/36#issuecomment-217860664

thomasvargiu commented 8 years ago

I'm going to update the PR just for ext-amqp. For ZF3 I will open another PR.

prolic commented 8 years ago

Perfect, many thanks

thomasvargiu commented 8 years ago

Done!

If you want, take a look here: AMQPAL
It's an abstraction layer that I wrote. It's not so perfect but it's completely tested. Maybe it can help you somehow.

prolic commented 8 years ago

👍