search

prolic / HumusAmqpModule

AMQP module for Zend Framework 2 to integrate RabbitMQ
https://humusamqp.readthedocs.io
MIT License
31 stars 13 forks source link

PSR 3 Log #37

Closed thomasvargiu closed 8 years ago

thomasvargiu commented 8 years ago

Instead to use Zend/Log, now it's possibile to use another PSR 3 compatible logger now.

Can we consider it to be merged for 0.2.0? I also would like to do some work to use container-interop and reduce other hard dependencies.

prolic commented 8 years ago

Looks good on first sight. Will do a better review tomorrow. I can release 0.2.0 soon, but for 1.0.0 there will be pretty much everything removed and depended on HumusAmqp instead. So the HumusAmqpModule will only be an addon for zf2 module manager integration. Container interop is also coming from within HumusAmqp, along with container config interop. There is however the question whether there will be a logger support or maybe it's better to just trigger events (zf3 event manager???) and let listeners handle logging. Thoughts?

prolic commented 8 years ago

For now there will be no event manager integration, only a logger. A change may come when there is enough need and feature requests for it.