prolificinteractive / Caishen

A Payment Card UI & Validator for iOS
MIT License
766 stars 119 forks source link

Card image for custom card type #75

Open ThibaultKlein opened 8 years ago

ThibaultKlein commented 8 years ago

Hi there,

Is there an easy way to provide a custom image for a custom card type?

I noticed that I could "hack" by having the card image name equal to the card type name, but imageForCardType is using self as the bundle, which returns nil if the image is contained in the project bundle and not the pod bundle.

public func imageForCardType(cardType: CardType) -> UIImage? {
    return UIImage(named: cardType.name, inBundle: self, compatibleWithTraitCollection: nil)
}

Thank you for your help!

DannyVancura commented 8 years ago

Hey! You should be able to implement and provide a CardTypeImageStore for a CardTextField yourself. This should be possible by either:

func imageForCardType(cardType: CardType) -> UIImage? {
  switch cardType {
    case .YourCardType:
      return yourImage
    default:
      return NSBundle(forClass: CardTextField.self).imageForCardType(cardType)
  }
}
ThibaultKlein commented 8 years ago

Thank you @DannyVancura, it works if I do your solution, although I still think there should be a way to provide a custom image without duplicating assets in our project. Ideally, we would like to specify the image in the card type model so it's trivial to create a new card type and provide all the structure you want at the same place. Let me know your thoughts on that!