prolificinteractive / material-calendarview

A Material design back port of Android's CalendarView
https://prolificinteractive.github.io/material-calendarview/
MIT License
5.92k stars 1.32k forks source link

AndroidX migration? #911

Open nareshkatta99 opened 5 years ago

nareshkatta99 commented 5 years ago

The users who are Using AndroidX can not use this awesome library. Please create another version for AndroidX migrated projects.

mpierucci commented 5 years ago

Agree, Im very tempted to use this library, but Ill have to migrate to Rx soon and thats an issue.

aldebaran798 commented 5 years ago

Yes please! This would be great!

kahakai commented 5 years ago

It works with AndroidX. Right now I'm using AS 3.3 with AGP 3.3.0 and Jetifier 1.0.0-beta02 (it was included for a fix with another library, don't remember exactly).

barnhill commented 5 years ago

@nareshkatta99 you probably just need to set these in your gradle.properties

android.useAndroidX=true android.enableJetifier=true

We are using this library and are using android X with Jetifier. This request is invalid but moving to newer AndroidX libraries would still be a good idea for future support library enhancements and updates.

nareshkatta99 commented 5 years ago

In some mobiles, I think, there is an issue while using this library in fragments. When using the library in Fragment, it says that android.support.v4.app.Fragment can not be found. The reason is that if you use androidx you are using androidx.fragment.app.Fragment the corresponding fragment.

barnhill commented 5 years ago

Are you using jetifier?