prolificinteractive / node-html-to-json

Parses HTML strings into objects using flexible, composable filters.
MIT License
120 stars 13 forks source link

Critical dependency: the request of a dependency is an expression #7

Open haddigan opened 7 years ago

haddigan commented 7 years ago

I'm importing into a create-react-app project and I'm getting a few warnings from webpack/ajv:

./~/ajv/lib/compile/index.js 13:21-34 Critical dependency: the request of a dependency is an expression ./~/ajv/lib/async.js 96:20-33 Critical dependency: the request of a dependency is an expression ./~/ajv/lib/async.js 119:15-28 Critical dependency: the request of a dependency is an expression

which apparently has to do with this webpack issue and dynamic requires.

According to this comment it can cause every file below a certain path to be included in the bundle, which seems to be the case here. My build with html-to-json weighs in at 1554 KB but without it builds to 229KB