search

prologin / concours-site

Source code of the Prologin contest website
https://gitlab.com/prologin/concours/site
GNU General Public License v3.0
10 stars 6 forks source link

correction-presence: fixing zadd function with "new" prototype and .error obsolete js #267

Closed Elfikurr closed 4 years ago

Elfikurr commented 4 years ago

Fixes #254

Hello,

This PR fixes the presence service on the correction page. The function zadd has changed, instead of having : zadd(name, data, score), we now have zadd(name, {data: score}). I first thought the error was in the JS, and after looking at the web console, I found that we were still using the .error function instead of the .fail one, so I changed that.

I have tested it locally, it now shows when 2 people are on the same contestant. I have not tested with more. When a staff members changes a value (by saving it), it now appears on the others screen.

Thank you.

codecov[bot] commented 4 years ago

Codecov Report

Merging #267 into master will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #267   +/-   ##
=======================================
  Coverage   48.81%   48.81%           
=======================================
  Files         194      194           
  Lines        9317     9317           
=======================================
  Hits         4548     4548           
  Misses       4769     4769
Impacted Files Coverage Δ
prologin/contest/staff_views.py 42.29% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 53a3172...3d136f8. Read the comment docs.