search

prologin / concours-site

Source code of the Prologin contest website
https://gitlab.com/prologin/concours/site
GNU General Public License v3.0
10 stars 6 forks source link

qcm: allow staff to complete the qcm and remove the correction display #273

Closed Elfikurr closed 2 years ago

Elfikurr commented 4 years ago

Fixes #152

Hello,

This PR simply removes the overridden post method in the qcm view. This allows the superusers to complete the qcm themselves, and prevents the correction from displaying. However, this means that people can now submit past qcm, and don't have the answers displayed on the form (they are are given when the qualifications are over though, in the archives). Are we OK with this ?

Thank you.

codecov[bot] commented 4 years ago

Codecov Report

Merging #273 into master will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   50.81%   50.83%   +0.01%     
==========================================
  Files         194      194              
  Lines        9408     9403       -5     
==========================================
- Hits         4781     4780       -1     
+ Misses       4627     4623       -4
Impacted Files Coverage Δ
prologin/qcm/views.py 54.68% <ø> (+2.51%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d2e17ec...2c76108. Read the comment docs.

cyril-amar commented 3 years ago

Is this PR still needed? The issue seems to be fixed in prod.

juli0z commented 2 years ago

Migrated to https://gitlab.com/prologin/concours/site/-/merge_requests/273