codecov[bot]
commented
3 years ago Codecov Report
Merging #339 (bab5690) into master (8ff0623) will increase coverage by
0.08%. The diff coverage is97.57%.
@@ Coverage Diff @@
## master #339 +/- ##
==========================================
+ Coverage 51.45% 51.53% +0.08%
==========================================
Files 197 203 +6
Lines 9632 9655 +23
==========================================
+ Hits 4956 4976 +20
- Misses 4676 4679 +3 | Impacted Files | Coverage Δ | |
|---|---|---|
| prologin/oidc_policy/apps.py | 0.00% <0.00%> (ø) |
|
| prologin/oidc_policy/oidc_authz.py | 100.00% <ø> (ø) |
|
| prologin/oidc_policy/oidc_scopes.py | 0.00% <ø> (ø) |
|
| prologin/users/admin.py | 100.00% <ø> (ø) |
|
| prologin/users/tests.py | 100.00% <ø> (ø) |
|
| prologin/oidc_policy/models.py | 96.42% <96.42%> (ø) |
|
| prologin/oidc_policy/admin.py | 100.00% <100.00%> (ø) |
|
| prologin/oidc_policy/migrations/0001_initial.py | 100.00% <100.00%> (ø) |
|
| prologin/oidc_policy/tests.py | 100.00% <100.00%> (ø) |
|
| prologin/prologin/settings/common.py | 97.85% <100.00%> (ø) |
|
| ... and 9 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8ff0623...6eba122. Read the comment docs.
As I had implemented it oidc_provider was a mandatory dependency since the model OpenIDClientPolicy was in users application.
I faced a problem when I tried to deploy semifinal site : I had to install (as in INSTALLED_APPS) oidc_provider to make the semifinal site work. This is not what we want.
This Pull Request aims to move the OpenIDClientPolicy Model from users to a new oidc_policy django application in order to make oidc_provider optional.
As there is no OpenIdClientPolicy objects on the prologin site, there is no need to make a migration.