prom3theu5 / aspirational-manifests

Handle deployments of .NET Aspire AppHost Projects
MIT License
702 stars 36 forks source link

`--container-builder` doesn't respect --non-interactive #208

Closed justinyoo closed 6 months ago

justinyoo commented 6 months ago

🔥 Bug Description

aspirate --version

8.0.1+5575b4754137411aea2977ae5519429d4745f3df

image

I tried the following command:

# Case 1
aspirate init -cr <container-registry-url> -ct latest --non-interactive

And I got this prompt, which shouldn't be displaying:

image

Then, I tried the following command:

# Case 2
aspirate init -cr <container-registry-url> -ct latest --container-builder Docker --non-interactive

And I got this error, which should take the parameter value case insensitive:

image

Then, I tried the following command:

# Case 3
aspirate init -cr <container-registry-url> -ct latest --container-builder docker --non-interactive

And I got this prompt, which shouldn't be displaying:

image

All of the cases above use the parameter --non-interactive, which should assume the default value.

🔍 Steps to Reproduce the Bug

Above 👆

🧯 Possible Solution

prom3theu5 commented 6 months ago

I admit the init command hasn't seen much love over the past few months, as most of its functionality is now usable from all the commands directly. I have a bug fix to perform tonight / this weekend so I will address this the same time - Thanks for reporting

prom3theu5 commented 6 months ago

Fixed in #211 Going out now in 8.0.2