search

prom3theu5 / aspirational-manifests

Handle deployments of .NET Aspire AppHost Projects
MIT License
702 stars 36 forks source link

"latest" tag always included during build #225

Closed patrickklaeren closed 5 months ago

patrickklaeren commented 5 months ago

🔥 Bug Description

I am trying to do aspirate build -ct 0.1.23 but this results in Aspirate running -p:ContainerImageTags="\"latest;0.1.23\"".

I want to not have latest included here.

Is this by design? Is there any way to ignore it?

🔍 Steps to Reproduce the Bug

  1. Run aspirate build -ct 0.1.23
  2. Latest tag is included

🧯 Possible Solution

Unknown. Could be by design?

prom3theu5 commented 5 months ago

Aye its by design - I guess I can remove it if ct has been set?

patrickklaeren commented 5 months ago

If possible.

My use case is trying to push an image for another channel where I don't necessarily want the image to be known as latest.

I appreciate this may not be how it's intended, if that is the case, I'm happy to close "my bug" accept the functionality as is, given this may be my quirk.

Though I suspect the semantics of passing in ct, would mean overriding any tags that would otherwise be fallen back on, including latest.

prom3theu5 commented 5 months ago

No problem 😃 It's a valid use case

Thanks for the sponsorship too!

prom3theu5 commented 5 months ago

This is handled in v8.0.6 - releasing now, will be on nuget in around 10 mins