Closed lopsided98 closed 3 years ago
Thanks for submitting this PR! I've already made some of the changes you have in my local copy, but I never pushed them until now. Specifically, commits bd4d9a3
and c02e592
, which add the (get|set)_beat_size
methods and fix the Default recursion problem. I'd recommend you cherry-pick the other commits into a new branch, and submit another PR with that branch. I'm happy with the rest of the changes, so once you do that I'll approve it ASAP.
This PR contains fixes for various bugs I ran into while using this crate, separated into different commits. Here is a summary:
Channel
needs to beSend
to be used as an rtic resource. I think this is safe, but I'm not totally sure what the potential safety issues are in this context.TransferDescriptor
was missing functions to adjust the beat size.TransferDescriptor
's implementation ofDefault
called itself, leading to infinite recursionSercom2Tx
andSercom3Rx
, causing all subsequent source IDs to be wrong.