search

prometheas / jira-2-omnifocus

Chrome extension for sending JIRA tickets to OmniFocus
24 stars 8 forks source link

Updated Linter & Rules #17

Closed gsumpster closed 4 years ago

gsumpster commented 7 years ago

Hi @prometheas, I've updated ESLint to 4.5.0 and changed the .eslintrc.yml to use airbnb-base. I've gone through and applied these rules to existing files as well!

Let me know if there are any issues!

gsumpster commented 7 years ago

Not entirely sure why this is happening, a clean install/lint seems to be working fine 😕

gsumpster commented 7 years ago

@prometheas I've done some research on this issue w/ HoundCI; I haven't been able to find a fix beyond disabling the 'import/no-unresolved' rule. I've tested this with a fresh clone and it will lint correctly using npm run lint and bitHound seems to be reflecting that too!

Let me know if there's anything that needs changing in this area.

prometheas commented 7 years ago

Hey man! Sorry this took me quite so long, but work was nuts. And then I gleefully popped off to holiday. Holidays are now wrapping up, however, and found some time and the inclination to open my laptop up again to review what you've done here. Please accept my apologies for the lag.

So, first of all: thank you so much for your interest and for your taking care to contribute ❤️

As it happens, I've already got a proper ES6 port in the works, which uses webpack to build the project's dist assets. (This new branch version also includes a Firefox port, but that's neither here nor there!)

Entirely unhelpfully, this branch exists on the Mac in my living room, and it's never been pushed to Github. Clearly I'm failing at distributed VCS.

Also, Mocha doesn't play especially well with lambda functions, lovely as they generally are, so I keep them out of my Mocha tests.