search

prometheas / jira-2-omnifocus

Chrome extension for sending JIRA tickets to OmniFocus
24 stars 8 forks source link

Add jira subdirectory to manifest #6

Closed afbroman closed 10 years ago

afbroman commented 10 years ago

This allows the "Send to OmniFocus" button to appear when JIRA is in a "jira" subdirectory.

prometheas commented 10 years ago

Hey Andrew,

Out of curiosity, does the following work for you in your manifest?:

http://_/__/browse/_, https://_/__/browse/_

Figure if I'm adding support for one subdir, may as well attempt to add multiple… if that works for your situation, I'll make a new release this week!

Thanks for your input, by the way.

On Mar 11, 2014, at 7:30, Andrew Broman notifications@github.com wrote:

This allows the "Send to OmniFocus" button to appear when JIRA is in a "jira" subdirectory.

You can merge this Pull Request by running

git pull https://github.com/afbroman/jira-2-omnifocus allow-subdirectory Or view, comment on, or merge it at:

https://github.com/prometheas/jira-2-omnifocus/pull/6

Commit Summary

Add jira subdirectory to manifest File Changes

M manifest.json (4) Patch Links:

https://github.com/prometheas/jira-2-omnifocus/pull/6.patch https://github.com/prometheas/jira-2-omnifocus/pull/6.diff — Reply to this email directly or view it on GitHub.

afbroman commented 10 years ago

Thanks, John! It does indeed work.

I was also not feeling very comfortable with the hardcoded directory name.

Please pardon my slow response, btw. I just now found your email in my spam folder for some reason.

Andrew

On Tue, Mar 11, 2014 at 7:23 AM, John Lianoglou notifications@github.comwrote:

Hey Andrew,

Out of curiosity, does the following work for you in your manifest?:

http://_/__/browse/_, https://_/__/browse/_

Figure if I'm adding support for one subdir, may as well attempt to add multiple... if that works for your situation, I'll make a new release this week!

Thanks for your input, by the way.

On Mar 11, 2014, at 7:30, Andrew Broman notifications@github.com wrote:

This allows the "Send to OmniFocus" button to appear when JIRA is in a "jira" subdirectory.

You can merge this Pull Request by running

git pull https://github.com/afbroman/jira-2-omnifocusallow-subdirectory Or view, comment on, or merge it at:

https://github.com/prometheas/jira-2-omnifocus/pull/6

Commit Summary

Add jira subdirectory to manifest File Changes

M manifest.json (4) Patch Links:

https://github.com/prometheas/jira-2-omnifocus/pull/6.patch

https://github.com/prometheas/jira-2-omnifocus/pull/6.diff

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com/prometheas/jira-2-omnifocus/pull/6#issuecomment-37289403 .

prometheas commented 10 years ago

Great news.

I've updated the Github repo, but will have to release an updated of the extension proper sometime this evening.

Thanks again for reporting the issue, and for coordinating on the fix!

afbroman commented 10 years ago

Thank you very much, John! The extension has been a huge help to me.

Andrew

On Sun, Mar 16, 2014 at 12:48 PM, John Lianoglou notifications@github.comwrote:

Great news.

I've updated the Github repo, but will have to release an updated of the extension proper sometime this evening.

Thanks again for reporting the issue, and for coordinating on the fix!

Reply to this email directly or view it on GitHubhttps://github.com/prometheas/jira-2-omnifocus/pull/6#issuecomment-37764288 .