search

prometheus-ai / fb-messenger-clj

A Clojure Library for the Facebook Messenger Bot API. Wiki: https://github.com/prometheus-ai/fb-messenger-clj/wiki
MIT License
14 stars 6 forks source link

Implementation of Messenger Plattform API #1

Closed sido378 closed 7 years ago

sido378 commented 7 years ago

implements Facebook Messenger API

Sgoettschkes commented 7 years ago

Is there any reason to use a different http library?

I'm wondering about #2 as it seems to be include the changes from this PR.

sido378 commented 7 years ago

@Sgoettschkes tbh this was a lazy decision as my code was already implemented with the http-kit library. Due to the clj-http library seemingly having more traction lately, and the http-kit library having stalled since last october, i changed back to clj-http in the latest commit

sido378 commented 7 years ago

Pull request has been cleaned of messy commit history

Sgoettschkes commented 7 years ago

The page-access-token is a better name than just token, maybe adjusting the setter as well would make sense (set-page-access-token)?

Other than that it looks good to me 🎈

sido378 commented 7 years ago

renamed setter & fixed a small intention bug - should be ready to merge now

Sgoettschkes commented 7 years ago

Awesome, thanks!