prometheus-community / PushProx

Proxy to allow Prometheus to scrape through NAT etc.
Apache License 2.0
719 stars 133 forks source link

Add crossbuild information to promu config #92

Closed ecksun closed 3 years ago

ecksun commented 4 years ago

This is required in order to build the docker-container (with make common-docker) and the architectures match those defined in the Makefile.

hansmi commented 3 years ago

With promu 0.7.0 running promu crossbuild at commit 0a8acfbc2bb0a4590 builds a whole set of architectures for me (including darwin-amd64, linux-386 and freebsd-armv6 to name a few; source). Doesn't that work for your usecase?

ecksun commented 3 years ago

hmm, I can't reproduce this on master.

I haven't looked into why that is, but I'm guessing it is related to the DOCKER_ARCHS variable in PushProx/Makefile didn't match the promu defaults.

Doesn't that work for your usecase?

Well, I'm not using promu at all for my usecase as I'm building in yocto and don't really feel like porting promu :)

I will close this because it seems to work, however I have a feeling this could become an issue in the future as well, when promu changes its default once more.