search

prometheus-community / ansible

Ansible Collection for Prometheus
https://prometheus-community.github.io/ansible/
Apache License 2.0
368 stars 130 forks source link

fix: make sure antsibull-changelog doesn't offend ansible-lint #367

Closed gardar closed 3 months ago

gardar commented 4 months ago

Finally figured out why the format of changelog.yaml gets messed up from time to time. I thought antsichaut was the culpit but it turns out that antsibull-changelog was responsible.

The workflow first passes the changelog to antsibull-changelog and then to antsichaut. antsibull-changelog rewrites the changelog even if there is no new change but antsichaut skips processing it when there are no new changes. And apparently the yaml that antsibull-changelog was putting out was not compatible with ansible-lint.

I've proposed fixes over at https://github.com/ansible-community/antsibull-changelog/pull/160 and https://github.com/ansible-community/antsibull-changelog/pull/165

SuperQ commented 4 months ago

Looks like the upstream change has been approved. Let's give it a bit to see if they merge.

gardar commented 4 months ago

Looks like the upstream change has been approved. Let's give it a bit to see if they merge.

Yeah sure, I've added another PR which fixes the sorting of the changelog entries as well: https://github.com/ansible-community/antsibull-changelog/pull/165