search

prometheus-community / ansible

Ansible Collection for Prometheus
https://prometheus-community.github.io/ansible/
Apache License 2.0
328 stars 116 forks source link

fix: scrape config files path #377

Open manzsolutions-lpr opened 1 month ago

manzsolutions-lpr commented 1 month ago

Unfortunately simply rebasing the original PR I missed that the paths in the actual role are wrong. I have now updated them ~and took the chance to also re-use the variable's value for the actual configuration not just the glob for copying~.

//edit: Cannot reuse variable since it would lead to /etc/prometheus/prometheus/scrapes/....

manzsolutions-lpr commented 1 month ago

@gardar I would also add "notify"-Statements to all the file uploads to trigger a reload of Prometheus. May I add this in this PR?

manzsolutions-lpr commented 1 month ago

@gardar Are these simple tests what you were looking for?

And I’m unsure if my approach for the "default" target is correct.

manzsolutions-lpr commented 1 month ago

I rebased the branch on the latest master but unfortunately now all CI jobs for 2.9 failed. It appears to me that this may be due to reasons unrelated to the branch but I do not see a way to retry the jobs except by maybe pushing a new commit.

Could anyone just re-trigger the CI jobs, please?

manzsolutions-lpr commented 3 weeks ago

I finally figured out that I couldn’t see CI job logs due to uMatrix not allowing XHR to "core.windows".

Anyway, the issue is entirely unrelated to this branch:

WARNING: Failed to pull docker image "quay.io/ansible/default-test-container:1.10.1".

manzsolutions-lpr commented 2 weeks ago

Unfortunately the situation hasn't changed with the latest commits: https://github.com/prometheus-community/ansible/actions/runs/9756163117/job/26925952278?pr=377

gardar commented 2 weeks ago

@manzsolutions-lpr there is a upcoming fix for the failing tests in #395