What support should a maintainer/project expect from prometheus-community?

prometheus-community / community

Prometheus & The Ecosystem Community Meeting Information

20 stars 3 forks source link

What support should a maintainer/project expect from prometheus-community? #10

Open RichiH opened 6 years ago

RichiH commented 6 years ago

Do we want to offer anything specific?

What immediately comes to mind is access to infrastructure for testing and such.

simonpasquier commented 6 years ago

Yes I see that a consistent and shared CI infrastructure makes it easier to keep up with the changes to the CI provider(s) as it has been experienced with GitHub integrations, Circle CI 1.0 → 2.0 and so on.

Also:

Dedicated website?
Binaries should be at least available from the GitHub release pages. Do they deserve a dedicated page similar to https://prometheus.io/download/?
Container image hosting?
Common tooling for releasing artifacts (part of CI probably).

carlpett commented 6 years ago

It was mentioned either in the mail thread or in the other issue here that major changes to "how things are done" could also be something which is done in a sweep over everything in this org (for example as the switch to Kingpin on the main org was done, and the upcoming suggested TLS implementations)

roidelapluie commented 6 years ago

regular vendor upgrade and releases

carlpett commented 6 years ago

@roidelapluie Isn't that going to be the job of the maintainers? Doing vendor updates and releases requires some amount of care and knowledge of the workings of the exporter, in my mind, rather than just bulk updating everything.

roidelapluie commented 6 years ago

That is untrue.

Vendor updates takes mainly good unit and acceptance testing.

roidelapluie commented 6 years ago

Plus everyone in the org is a maintainer in my vision.

carlpett commented 6 years ago

I'd agree that a good acceptance test coverage would reduce risk. However, I think this is lacking in a significant majority of exporters? I wouldn't say creating them is simple either, in most cases it would require setting up a fair chunk of infrastructure and exercising (which may in some cases also have a non-trivial financial impact).

brian-brazil commented 6 years ago

However, I think this is lacking in a significant majority of exporters?

The JMX exporter is the only one I know of with testing to this level. Some of the push-ones like influxdb/statsd/graphite probably also count. (Node exporter has extensive testing, but I'm not counting it here as it's running against fake data rather than a real kernel, and doesnt cover all OSes either).

Updating something like Kingpin can be done in bulk, updating libraries related to an exporter's key role less so. It's the same issue we have with SD and notifiers.