prometheus-community / community

Prometheus & The Ecosystem Community Meeting Information
20 stars 3 forks source link

Move Apache exporter https://github.com/Lusitaniae/apache_exporter to community #47

Open frittentheke opened 1 year ago

frittentheke commented 1 year ago

I'd like to propose moving the popular apache exporter to this community. I bluntly brought up the question with the creator @lusitaniae in issue https://github.com/Lusitaniae/apache_exporter/issues/145 and seems to like the idea.

With this being the de-facto standard exporter for Apache (see https://prometheus.io/docs/instrumenting/exporters/#http) already and Apache still being all over the place I believe it would be great addition.

roidelapluie commented 1 year ago

Do you have specific concerns with the apache exporter being independent? I wonder if we should move the exporter to the community without knowing what the future would bring - the exporter could be replaced by native solutions like https://github.com/ConSol/apache_mod_prometheus_status in the future.

I'd also note that I have commit access to the apache_exporter, even if I don't actively maintain it at the moment.

frittentheke commented 1 year ago

No there is no particular concern, but rather the impression that exporters in the community are aligned in their use of e.g. the exporter toolkit and features like support for TLS and auth. Nothing that cannot be achieved independently no, but I simply appreciate that the community exporters are treated in this way.

Thanks for the hint about https://github.com/ConSol/apache_mod_prometheus_status - having native metrics support without the need to run an exporter is nice - Just like HAProxy does it. But this still just being a module will likely make this an option, not a full replacement for an exporter to mod_status. Some installs simply might not be able or want to add modules to their Apaches.

blkperl commented 1 year ago

To echo what @frittentheke said I think there are benefits to having the exporter under the prometheus-community namespace and it allows the author to easily walk away from the project if they no longer wish to maintain it in the future without causing a potential disruption for users.

frittentheke commented 1 year ago

@Lusitaniae did say he was open to move the exporter over and also believes there could be benefits, see https://github.com/Lusitaniae/apache_exporter/issues/145#issuecomment-1347152613.

I understand @roidelapluie that prometheus-community cannot simply adopt ever exporter out there. But frankly the Apache webserver is really extremely common.

While I also believe in adding native Prometheus metrics support, as services like HAProxy, RabbitMQ and others did implment for their software and what would be possible with https://github.com/ConSol/apache_mod_prometheus_status this is still an "external" module (read: not something natively provided by Apache Httpd). So even some time down the road not everybody is comfortable adding such a module and rather use the well aged mod_status and scrape that scoreboard via an exporter.

blkperl commented 11 months ago

@roidelapluie @SuperQ any update on considering this request?