search

prometheus-community / helm-charts

Prometheus community Helm charts
Apache License 2.0
5.04k stars 5k forks source link

[kube-prometheus-stack] Support `additionalArgs` on `thanosRulerSpec` #4007

Closed clux closed 8 months ago

clux commented 11 months ago

Is your feature request related to a problem ?

This is to primarily to allow enabling stateless rulers via remote write which currently uses additionalArgs to provide a remote write config.

Examples from issues show this can be done inline: https://github.com/prometheus-operator/prometheus-operator/issues/4451#issuecomment-1682373352

Describe the solution you'd like.

Expose additionalArgs on thanosRulerSpec with the example from the linked issue.

Happy to try to send a PR.

Describe alternatives you've considered.

none available yet afaikt. also good to be able to support this for any potential future features.

Additional context.

Expected implementation location: https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/templates/thanos-ruler/ruler.yaml ThanosRuler docs for the new field: https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api.md#thanosruler

stale[bot] commented 10 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

mattiasnensen commented 10 months ago

I want this to be prioritized.

Best regards, Mattias N.

clux commented 9 months ago

PR for this is on #4092. Reviews are appreciated 🙏