search

prometheus-community / helm-charts

Prometheus community Helm charts
Apache License 2.0
4.82k stars 4.92k forks source link

[kube-prometheus-stack] Add Gateway API templates #4622

Open e3b0c442 opened 1 week ago

e3b0c442 commented 1 week ago

Is your feature request related to a problem ?

I need to manually add HTTPRoutes when trying to use Gateway API for ingress

Describe the solution you'd like.

Now that Gateway API has reached v1 and implementations are beginning to land, add Gateway API templates (HTTPRoute) that can be chosen in lieu of Ingress resources.

Describe alternatives you've considered.

Additional context.

Using kube-prometheus-stack as a filler here, I understand the ingress is a part of the subordinate charts.

jkroepke commented 1 week ago

@monotek @GMartinez-Sisti @QuentinBisson I think, adding Gateway API feels natural, since ingress API reached the feature complete state and may not receive new features.

Do you already have a good template for HTTPRoutes? Should we support Gateway or BackendTLSPolicy as well? Do you have Gateway API already in use on your company and already develop a good base?

With some coordination, we can deliver the same experience for all end-users across all prometheus community helm charts.

GMartinez-Sisti commented 1 week ago

@monotek @GMartinez-Sisti @QuentinBisson I think, adding Gateway API feels natural, since ingress API reached the feature complete state and may not receive new features.

Do you already have a good template for HTTPRoutes? Should we support Gateway or BackendTLSPolicy as well? Do you have Gateway API already in use on your company and already develop a good base?

With some coordination, we can deliver the same experience for all end-users across all prometheus community helm charts.

I think we should support both for now, clusters that were created some time ago (even if they are on the latest k8s version) are very likely to still use ingress controllers that might not support this.

jkroepke commented 1 week ago

Definitive! I was not talking about removing ingress.

jkroepke commented 6 days ago

An initial draft can be found here: https://github.com/prometheus-community/helm-charts/pull/4646

Some Feedback would be appreciated. @e3b0c442 I would like to know, if that would meets your expectation.

QuentinBisson commented 6 days ago

I Can take a look but i'm not familiar with the gateway api yet. Also, is it enabled for the grafana depencency? If you did not we might want to make the gateway api enable flag global as well?

jkroepke commented 6 days ago

No, but you can setup an PR which I can review/approve at grafana 😅