Open d4nyll opened 1 month ago
Based on the name of the chart kube-prometheus-stack and the first line of the README.md:
kube-prometheus-stack
README.md
Installs the kube-prometheus stack...
It gives the impression that the chart will install everything in the list in the kube-prometheus README.md, namely:
kube-prometheus
Components included in this package: The Prometheus Operator Highly available Prometheus Highly available Alertmanager Prometheus node-exporter Prometheus blackbox-exporter Prometheus Adapter for Kubernetes Metrics APIs kube-state-metrics Grafana
Components included in this package:
However, kube-prometheus-stack does not include the Prometheus Adapter nor blackbox-exporter, but does include prometheus-windows-exporter.
blackbox-exporter
prometheus-windows-exporter
Change the README.md to be explicit about these caveats.
Rename the chart to dissociate itself from kube-prometheus
It can avoid issues like https://github.com/prometheus-community/helm-charts/issues/1974 where someone expects Prometheus Adapter to be installed when, in reality, it isn't.
Would you iike to create an PR here?
Is your feature request related to a problem ?
Based on the name of the chart
kube-prometheus-stack
and the first line of theREADME.md
:It gives the impression that the chart will install everything in the list in the
kube-prometheus
README.md
, namely:However,
kube-prometheus-stack
does not include the Prometheus Adapter norblackbox-exporter
, but does includeprometheus-windows-exporter
.Describe the solution you'd like.
Change the
README.md
to be explicit about these caveats.Describe alternatives you've considered.
Rename the chart to dissociate itself from
kube-prometheus
Additional context.
It can avoid issues like https://github.com/prometheus-community/helm-charts/issues/1974 where someone expects Prometheus Adapter to be installed when, in reality, it isn't.