prometheus-community / helm-charts

Prometheus community Helm charts
Apache License 2.0
5.12k stars 5.02k forks source link

[kube-prometheus-stack] Fix jobLabel on prometheus-node-exporterchange to commonLabels #4850

Closed monchaio closed 2 months ago

monchaio commented 2 months ago

What this PR does / why we need it

When crate prometheus with existing chart I found that jobLabel from metrics of node exporters are not "node-exporter". After investigation I found that we need to use commonLabels instead of podLabels. https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus-node-exporter/templates/_helpers.tpl#L46.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer

Checklist