[kube-prometheus-stack] add tpl to some templates

prometheus-community / helm-charts

Prometheus community Helm charts

Apache License 2.0

5.12k stars 5.02k forks source link

[kube-prometheus-stack] add tpl to some templates #4901

Open denzhel opened 1 month ago

denzhel commented 1 month ago

What this PR does / why we need it

We're moving our infra charts from Terraform to ArgoCD/ApplicationSets and we need the ability to template nodeSelector and tolerations

[X] DCO signed
[x] Chart Version bumped
[X] Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

jkroepke commented 1 month ago

Your change is already covered by additionalConfig, e.g. alertmanager.alertmanagerSpec.additionalConfig

alertmanager:
  alertmanagerSpec:
    additionalConfig:
      nodeSelector: {}

That should solve your case?

denzhel commented 1 month ago

Your change is already covered by additionalConfig, e.g. alertmanager.alertmanagerSpec.additionalConfig
alertmanager:
  alertmanagerSpec:
    additionalConfig:
      nodeSelector: {}
That should solve your case?

Thanks @jkroepke for the quick response !

Correct, that solved the issue I had with alertmanager and prometheus but I'm still having the issue with prometheus-operator since there is no prometheusOperatorSpec.additionalConfig handling inside the template files.

I updated my PR accordingly.

denzhel commented 1 month ago

Hi @jkroepke :) can this be merged please ?